Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to the probabilistic linear solver implementation #656

Merged
merged 17 commits into from
Mar 11, 2022
Merged

Improvements to the probabilistic linear solver implementation #656

merged 17 commits into from
Mar 11, 2022

Conversation

JonathanWenger
Copy link
Contributor

@JonathanWenger JonathanWenger commented Mar 3, 2022 •
edited
Loading

In a Nutshell

This PR introduces a bunch of changes which improve the modular implementation of the probabilistic linear solver.

Detailed Description

Changes in this PR:

Related Issues

Implements part of #622

@JonathanWenger JonathanWenger added linalg Issues related to linear algebra improvement Improvements of existing functionality labels Mar 3, 2022
@JonathanWenger JonathanWenger self-assigned this Mar 3, 2022
@JonathanWenger JonathanWenger changed the title Improvements to the probabilistic linear solver implementation. Improvements to the probabilistic linear solver implementation Mar 3, 2022
@codecov
Copy link

codecov bot commented Mar 3, 2022 •
edited
Loading

Codecov Report

Merging #656 (fcf085f) into main (f93bb38) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
- Coverage   90.14%   90.13%   -0.01%     
==========================================
  Files         191      191              
  Lines        7211     7224      +13     
  Branches     1146     1149       +3     
==========================================
+ Hits         6500     6511      +11     
- Misses        465      467       +2     
  Partials      246      246
Impacted Files Coverage Δ
...s/information_ops/_linear_solver_information_op.py 100.00% <ø> (ø)
...num/linalg/solvers/_probabilistic_linear_solver.py 100.00% <100.00%> (ø)
src/probnum/linalg/solvers/_state.py 100.00% <100.00%> (ø)
.../solvers/belief_updates/solution_based/__init__.py 100.00% <100.00%> (ø)
...olution_based/_projected_residual_belief_update.py 100.00% <100.00%> (ø)
...um/linalg/solvers/beliefs/_linear_system_belief.py 91.42% <100.00%> (+0.51%) ⬆️
...probnum/linalg/solvers/information_ops/__init__.py 100.00% <100.00%> (ø)
...alg/solvers/information_ops/_projected_residual.py 100.00% <100.00%> (ø)
...num/linalg/solvers/policies/_conjugate_gradient.py 91.42% <100.00%> (-0.24%) ⬇️
...m/linalg/solvers/policies/_linear_solver_policy.py 100.00% <100.00%> (ø)
... and 4 more

@JonathanWenger JonathanWenger added the refactoring Refactoring of existing functionality label Mar 3, 2022
@JonathanWenger JonathanWenger marked this pull request as ready for review March 3, 2022 19:05
marvinpfoertner
marvinpfoertner approved these changes Mar 11, 2022
View reviewed changes
Copy link
Collaborator

@marvinpfoertner marvinpfoertner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@JonathanWenger JonathanWenger merged commit 98bd6d2 into probabilistic-numerics:main Mar 11, 2022
@JonathanWenger JonathanWenger deleted the pls-improvements branch March 11, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinpfoertner marvinpfoertner marvinpfoertner approved these changes

Assignees

@JonathanWenger JonathanWenger

Labels
improvement Improvements of existing functionality linalg Issues related to linear algebra refactoring Refactoring of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonathanWenger @marvinpfoertner